[PATCH 3/6] pktgen: Fix kernel_thread() fail leak.
From: Luiz Fernando Capitulino
Date: Sat Feb 25 2006 - 14:07:21 EST
Free all the alocated resources if kernel_thread() call fails.
Signed-off-by: Luiz Capitulino <lcapitulino@xxxxxxxxxxxxxxx>
---
net/core/pktgen.c | 11 +++++++++--
1 files changed, 9 insertions(+), 2 deletions(-)
c3fd9c4bbddab18349563c0c5d90c4bf0002de99
diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index 2d6b147..1c565fe 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -3082,6 +3082,7 @@ static struct pktgen_thread *__init pktg
static int __init pktgen_create_thread(const char *name, int cpu)
{
+ int err;
struct pktgen_thread *t = NULL;
struct proc_dir_entry *pe;
@@ -3120,9 +3121,15 @@ static int __init pktgen_create_thread(c
t->removed = 0;
- if (kernel_thread((void *)pktgen_thread_worker, (void *)t,
- CLONE_FS | CLONE_FILES | CLONE_SIGHAND) < 0)
+ err = kernel_thread((void *)pktgen_thread_worker, (void *)t,
+ CLONE_FS | CLONE_FILES | CLONE_SIGHAND);
+ if (err < 0) {
printk("pktgen: kernel_thread() failed for cpu %d\n", t->cpu);
+ remove_proc_entry(t->name, pg_proc_dir);
+ list_del(&t->th_list);
+ kfree(t);
+ return err;
+ }
return 0;
}
--
1.2.1.g3397f9
--
Luiz Fernando N. Capitulino
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/