Re: [Patch 5/7] synchronous block I/O delays

From: Arjan van de Ven
Date: Mon Feb 27 2006 - 03:26:53 EST



> +static inline void delayacct_blkio(void)
> +{
> + if (unlikely(current->delays && delayacct_on))
> + __delayacct_blkio();
> +}

why is this unlikely?

> + u64 blkio_delay; /* wait for sync block io completion */

this misses O_SYNC, msync(), and general throttling.
I get the feeling this is being measured at the wrong level
currently.... since the number of entry points that needs measuring at
the current level is hardly finite...


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/