Re: [Patch 5/7] synchronous block I/O delays

From: Arjan van de Ven
Date: Mon Feb 27 2006 - 04:22:41 EST


On Mon, 2006-02-27 at 04:13 -0500, Shailabh Nagar wrote:
> Arjan van de Ven wrote:
>
> >>+static inline void delayacct_blkio(void)
> >>+{
> >>+ if (unlikely(current->delays && delayacct_on))
> >>+ __delayacct_blkio();
> >>+}
> >>
> >>
> >
> >why is this unlikely?
> >
> >
> delayacct_on is expected to be off most of the time, hence the compound is
> unlikely too.


ok that opens the question: why is this a runtime tunable?
Is it really worth all this complexity?


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/