Re: [patch 05/39] [PATCH] i386: Move phys_proc_id/early intel workaround to corr

[Andi Kleen]

> ==> This has been in this location since at least 2.6.9.  If it's also
> needed in generic_identify(), fine, but it should be left here too.  I
> think this patch in 2.6.16-rc is wrong.  The comment for this function says
> it really needs accurate cache alignment information, presumably because
> it's needed for early boot setup, and without this it won't be accurate.

Actually it's ok because early_cpu_detect() is called from setup_arch()
which is way before kmem_cache_init() which is the first user of the 
alignment information.

So I think the patch is fine. You're right the comment could need updating
though.

Thanks for the review.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/