Re: [PATCH 1/4] change buffer_head.b_size to size_t

From: Andrew Morton
Date: Wed Mar 01 2006 - 20:47:21 EST


Badari Pulavarty <pbadari@xxxxxxxxxx> wrote:
>
> + size_t b_size; /* size of mapping */
> + char *b_data; /* pointer to data within the page */
>
> struct block_device *b_bdev;
> bh_end_io_t *b_end_io; /* I/O completion */
> void *b_private; /* reserved for b_end_io */
> struct list_head b_assoc_buffers; /* associated with another mapping */
> + atomic_t b_count; /* users using this buffer_head */
> };
>
> /*
> Index: linux-2.6.16-rc5/fs/buffer.c
> ===================================================================
> --- linux-2.6.16-rc5.orig/fs/buffer.c 2006-02-26 21:09:35.000000000 -0800
> +++ linux-2.6.16-rc5/fs/buffer.c 2006-02-27 08:22:37.000000000 -0800
> @@ -432,7 +432,8 @@ __find_get_block_slow(struct block_devic
> printk("__find_get_block_slow() failed. "
> "block=%llu, b_blocknr=%llu\n",
> (unsigned long long)block, (unsigned long long)bh->b_blocknr);
> - printk("b_state=0x%08lx, b_size=%u\n", bh->b_state, bh->b_size);
> + printk("b_state=0x%08lx, b_size=%lu\n", bh->b_state,
> + (unsigned long)bh->b_size);

We print size_t with `%z'. Hence the cast isn't needed.

(I'll edit the diff..)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/