Re: [PATCH] pcmcia: add another ide-cs CF card id

[Jeff Garzik]

Arjan van de Ven wrote:
> On Thu, 2006-03-02 at 12:42 +0100, Jens Axboe wrote:
>
> > On Thu, Mar 02 2006, Arjan van de Ven wrote:
> >
> > > On Thu, 2006-03-02 at 06:17 -0500, Jeff Garzik wrote:
> > >
> > > > Dominik Brodowski wrote:
> > > >
> > > > > On Wed, Mar 01, 2006 at 06:36:17PM -0500, Jeff Garzik wrote:
> > > > >
> > > > > > Linux Kernel Mailing List wrote:
> > > > > >
> > > > > > > commit 42935656914b813c99f91cbac421fe677a6f34ab
> > > > > > > tree d37a0d20998f4d87a4bd014300f707c3852ef5f9
> > > > > > > parent 82d56e6d2e616bee0e712330bad06b634f007a46
> > > > > > > author David Brownell <david-b@xxxxxxxxxxx> Wed, 25 Jan 2006 22:36:32 -0800
> > > > > > > committer Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx> Wed, 01 Mar 2006 
> > > >
> > > > > > Why was this not CC'd to the IDE maintainer, and linux-ide?
> > > >
> > > > > For it is trivial, PCMCIA-related and my time is very limited these days.
> > > >
> > > > That's pathetic.  You couldn't even CC linux-kernel on your answer.  And 
> > > > this is not even the first or second time you've been asked to CC a 
> > > > maintainer.
> > >
> > > I personally don't consider that maintainers have a right to demand
> > > CC's. Sure it's polite and good to CC them, but that's not the same as
> > > having the right to demand this.
> >
> > How do you expect the patch to be picked up, if you don't cc the
> > maintainer? Looking up the maintainer is trivial. We can't always rely
> > on akpm forwarding patches, seems a lot saner to put the onus on the
> > submitter to make sure it gets to the right place.
>
>
>
> ok so this was adding a PCMCIA ID to a PCMCIA IDE driver. The patch was
> mailed first to the pcmcia mailing list.
>
> This is one of those drivers that hits multiple maintainers, arguable
> Dominik is the primary maintainer of this driver. The patch doesn't do
> ANYTHING structural to the driver, all it does it adds a device ID.
> there is therefore zero IDE related change in it.
>
> Sure I can it being nice to CC linux-ide ANYWAY, but, to be honest,
> while I see that is important for changes to the driver that change the
> structure of it and how it interacts with the IDE layer, I fail to see
> the hard required reason for that for just adding a *PCMCIA* ID.
>
> I think Jeff is a bit overreacting in this case.

About a quarter of the time when non-netdev maintainers add IDs, through 
the magic of merges, we've wound up with duplicate IDs in the driver. 
I've snipped several duplicate IDs from tulip and other net drivers over 
the years.

Further, in the past Brodo has _already_ been asked to CC relevant 
maintainers and lists -- or at least LKML -- with his patches.  He has 
established a pattern of lacking time to add CC's to his emails; it 
wasn't just this incident.

Where is the peer review?

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/