Re: [PATCH 1/15] EDAC: switch to kthread_ API

From: Arjan van de Ven
Date: Fri Mar 03 2006 - 04:13:58 EST


On Thu, 2006-03-02 at 18:30 -0800, Andrew Morton wrote:
> Dave Peterson <dsp@xxxxxxxx> wrote:
> >
> > schedule_timeout((HZ * poll_msec) / 1000);
> > try_to_freeze();
> > + __set_current_state(TASK_RUNNING);
>
> schedule() and schedule_timeout*() always return in state TASK_RUNNING, so
> I'll take that out of there.
>
> We might as well use schedule_timeout_interruptible(), too. As a bonus, we
> get to delete that spelling mistake ;)


or even msleep variant ;)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/