Re: [PATCH 7/15] EDAC: i82875p cleanup

From: Thayne Harbaugh
Date: Fri Mar 03 2006 - 20:41:14 EST


On Fri, 2006-03-03 at 10:47 -0800, Dave Peterson wrote:
> On Thursday 02 March 2006 18:30, Andrew Morton wrote:
> > Dave Peterson <dsp@xxxxxxxx> wrote:
> > > +#ifdef CORRECT_BIOS
> > > +fail0:
> > > +#endif
> >
> > What is CORRECT_BIOS? Is the fact that it's never defined some sort of
> > commentary? ;)
>
> I'm not sure about this. I'm cc'ing Thayne Harbaugh and Wang Zhenyu since
> their names are in the credits for the i82875p module. Maybe they can
> provide some info.

This is something that is my style - I don't care for "#if 0" or "#if
1". I usually drop a "#undef COMMENT_TAG" someplace with a "/* ... */"
comment next to it so that it's not some unknown tag.

I haven't looked through the code yet so I can't remember if it's
something I left and if it is, what it does.

I just looked, and I don't recognize it - "cvs annotate" lists it ass
being last touched by dsp_llnl ;^).


--
A silly version!
so I fix the stripping beat
with bitter sleep snot.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/