Re: [PATCH] change kbuild to not rely on incorrect GNU make behavior

[Paul D. Smith]

%% Sam Ravnborg <sam@xxxxxxxxxxxx> writes:

  sr> Thanks Paul.
  sr> Adapted to -rc4 and applied to my kbuild tree which I have pushed out.
  sr> For reference I added the applied patch below.

OK.  Note that this:

  sr> -.PHONY: tar%pkg
  sr> +PHONY += tar%pkg
  sr>  tar%pkg:

won't do what you expect.  tar%pkg is a pattern rule, but .PHONY doesn't
take patterns so you're declaring the actual file named literally
'tar%pkg' to be phony.


Cheers!

-- 
-------------------------------------------------------------------------------
 Paul D. Smith <psmith@xxxxxxx>          Find some GNU make tips at:
 http://www.gnu.org                      http://make.paulandlesley.org
 "Please remain calm...I may be mad, but I am a professional." --Mad Scientist
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/