Re: [PATCH 6/6] Optimise d_find_alias() [try #6]

From: David Howells
Date: Tue Mar 07 2006 - 08:22:02 EST


Nick Piggin <nickpiggin@xxxxxxxxxxxx> wrote:

> Having the smp_rmb() here implies there is some sort of memory barrier
> based synchronisation protocol at a higher level (than this function),
> because you don't actually do anything before them smp_rmb() here.
>
> So can you comment what that is?

Hmmm... That probably shouldn't be there. I don't think Andrew Morton and I
actually came to an agreement as to whether it's necessary. I don't think it
is, he thought that it was, though he may have changed his mind.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/