Re: [PATCH rc5-mm] pids: kill PIDTYPE_TGID

[Eric W. Biederman]

Oleg Nesterov <oleg@xxxxxxxxxx> writes:

> depends on
>
> 	pidhash-dont-count-idle-threads.patch
> 	pidhash-kill-switch_exec_pids.patch
>
> otherwise (I think) it is orthogonal to all tref/proc changes.

You also depend on your recent change to call __unhash_process
under the sighand lock.  Since the ->tgrp is protected by
the sighand lock.

> This patch kills PIDTYPE_TGID pid_type thus saving one hash table
> in kernel/pid.c and speeding up subthreads create/destroy a bit.
> It is also a preparation for the further tref/pids rework.
>
> This patch adds 'struct list_head tgrp' to 'struct task_struct'
> instead. Note that ->tgrp need not to be rcu safe.

Is there a reason for this?  I think at least proc could easily
take advantage of an rcu safe implementation.

Hmm.  At the moment proc is only taking the tasklist_lock during
traversal so we may have a problem with the list_add anyway.

Also could we name the member not ->tgrp but ->threads?
I keep half expecting tgrp to be a number, and have a hard
time not mispelling it tpgrp.

> We don't detach group leader from PIDTYPE_PID namespace until another
> thread inherits it's ->pid == ->tgid, so we are safe wrt premature
> free_pidmap(->tgid) call.

Agreed.

> Currently there are no users of find_task_by_pid_type(PIDTYPE_TGID).
> Should the need arise, we can use find_task_by_pid()->group_leader.
>
>  include/linux/pid.h   |    1 -
>  include/linux/sched.h |   10 +++++++---
>  kernel/exit.c         |   10 +---------
>  kernel/fork.c         |    4 +++-
>  4 files changed, 11 insertions(+), 14 deletions(-)

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/