Re: [patch] i386 spinlocks: disable interrupts only if we enabled them

From: Benjamin LaHaise
Date: Tue Mar 07 2006 - 21:55:23 EST


On Wed, Mar 08, 2006 at 01:43:08AM +0100, Ingo Molnar wrote:
> we dont inline that code anymore. So i think the optimization is fine.

Why is that? It adds memory traffic that has to be synchronized
before the lock occurs and clobbered registers now in the caller.

-ben
--
"Time is of no importance, Mr. President, only life is important."
Don't Email: <dont@xxxxxxxxx>.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/