[PATCH] ext3 "nobh" writeback support for filesystems blocksize <pagesize

[Badari Pulavarty]

Hi,

Reading through the code, I don't see a reason why we can't
support "nobh" option for filesystems with blocksize < pagesize.
Base infrastructure already handles it and kicks it back to
creating buffer_heads if it can't handle. 

Of course, there may be performance reasons why we don't want
to do this.

Anyway, following patch at least enables "nobh" option for 
blocksize < pagesize cases.

Thanks,
Badari

There is no valid reason why we can't support "nobh" option
for filesystems with blocksize != PAGESIZE. 

This patch lets them use "nobh" option for writeback mode
for blocksize < pagesize.

Signed-off-by: Badari Pulavarty <pbadari@xxxxxxxxxx>
Index: linux-2.6.16-rc5/fs/ext3/super.c
===================================================================
--- linux-2.6.16-rc5.orig/fs/ext3/super.c	2006-03-10 10:38:39.000000000 -0800
+++ linux-2.6.16-rc5/fs/ext3/super.c	2006-03-10 13:58:07.000000000 -0800
@@ -1677,12 +1677,6 @@ static int ext3_fill_super (struct super
 	}
 
 	if (test_opt(sb, NOBH)) {
-		if (sb->s_blocksize_bits != PAGE_CACHE_SHIFT) {
-			printk(KERN_WARNING "EXT3-fs: Ignoring nobh option "
-				"since filesystem blocksize doesn't match "
-				"pagesize\n");
-			clear_opt(sbi->s_mount_opt, NOBH);
-		}
 		if (!(test_opt(sb, DATA_FLAGS) == EXT3_MOUNT_WRITEBACK_DATA)) {
 			printk(KERN_WARNING "EXT3-fs: Ignoring nobh option - "
 				"its supported only with writeback mode\n");


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/