[2.6 patch] drivers/scsi/ibmmca.c: fix a NULL pointer dereference

From: Adrian Bunk
Date: Fri Mar 10 2006 - 17:22:23 EST


The variable was dereferenced only if it was NULL (sic)...

Spotted by the Coverity checker.


Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>

--- linux-2.6.16-rc5-mm3-full/drivers/scsi/ibmmca.c.old 2006-03-10 20:39:03.000000000 +0100
+++ linux-2.6.16-rc5-mm3-full/drivers/scsi/ibmmca.c 2006-03-10 20:41:47.000000000 +0100
@@ -2357,8 +2357,7 @@ static int ibmmca_proc_info(struct Scsi_
spin_lock_irqsave(hosts[i]->host_lock, flags); /* Check it */
host_index = i;
if (!shpnt) {
- len += sprintf(buffer + len, "\nIBM MCA SCSI: Can't find adapter for host number %d\n",
- shpnt->host_no);
+ len += sprintf(buffer + len, "\nIBM MCA SCSI: Can't find adapter");
return len;
}
max_pun = subsystem_maxid(host_index);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/