Re: [PATCH ] drivers/scsi/scsi.c - export reprobe

From: Arjan van de Ven
Date: Tue Mar 14 2006 - 11:29:09 EST


On Tue, 2006-03-14 at 16:08 +0000, Christoph Hellwig wrote:
> On Tue, Mar 14, 2006 at 07:35:24AM -0800, Greg KH wrote:
> > On Mon, Mar 13, 2006 at 05:52:43PM -0700, Moore, Eric wrote:
> > > Request for exporting device_reprobe -
> > > This is scsi wrapper portion.
> >
> > Is this even really needed? It's just a single pointer dereference...
>
> We don't want SCSI LLDDs to know about implementations details like
> sdev->sdev_gendev. Of course an inline or a macro could do this aswell.


this looks like a good candidate for an inline yes ;)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/