Re: [2.6 patch] crypto/aes.c: array overrun

From: Valdis . Kletnieks
Date: Tue Mar 14 2006 - 15:23:58 EST


On Sat, 11 Mar 2006 13:41:16 +1100, Herbert Xu said:

> OK this is not pretty but it is actually correct. Notice how we only
> overstep the mark for E_KEY but never for D_KEY. Since D_KEY is only
> initialised after this, it is OK for us to trash the start of D_KEY.

I think a big comment block describing this behavior is called for,
as it carries an implicit requirement that D_KEY and E_KEY remain
adjacent in memory. Anybody allocating space between them is in for
a rude awakening....

Attachment: pgp00000.pgp
Description: PGP signature