Re: [PATCH] Add SA_PERCPU_IRQ flag support

From: Christoph Hellwig
Date: Thu Mar 16 2006 - 21:07:14 EST


On Thu, Mar 16, 2006 at 06:31:14PM -0600, Dimitri Sivanich wrote:
> The generic request_irq/setup_irq code should support the SA_PERCPU_IRQ flag.
>
> Not sure why it was left out, but this patch adds that support.
>
> Signed-off-by: Dimitri Sivanich <sivanich@xxxxxxx>
>
> Index: linux/kernel/irq/manage.c
> ===================================================================
> --- linux.orig/kernel/irq/manage.c 2006-03-16 14:05:27.957927445 -0600
> +++ linux/kernel/irq/manage.c 2006-03-16 14:06:02.283661867 -0600
> @@ -201,6 +201,9 @@ int setup_irq(unsigned int irq, struct i
> * The following block of code has to be executed atomically
> */
> spin_lock_irqsave(&desc->lock,flags);
> + if (new->flags & SA_PERCPU_IRQ) {
> + desc->status |= IRQ_PER_CPU;
> + }

looks good, although the braces aren't really needed for single-line
conditionals.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/