[patch 1/1] scsi mca_53c9x missing return check for request_region()

From: Laurent Wandrebeck
Date: Fri Mar 17 2006 - 08:26:42 EST


Hi,
in drivers/scsi/mca_53c9x.c, request_region() is called without checking the return
value. Here is a simple patch to fix it.
Patch against 2.6.16-rc6-git8.
Please CC me on replies.
Regards.

Signed-off-by: Laurent Wandrebeck <l.wandrebeck@xxxxxxx>

--- linux-2.6.16-rc6/drivers/scsi/mca_53c9x.c.ori 2006-03-11 23:12:55.000000000 +0100
+++ linux-2.6.16-rc6/drivers/scsi/mca_53c9x.c 2006-03-17 14:20:44.000000000 +0100
@@ -195,7 +195,15 @@ static int mca_esp_detect(struct scsi_ho
return 0;
}

- request_region(tmp_io_addr, 32, "NCR 53c9x SCSI");
+ if (!request_region(tmp_io_addr, 32, "NCR 53c9x SCSI")) {
+ printk("Unable to request region %d.\n",
+ tmp_io_addr);
+ free_dma(esp->dma);
+ free_irq(esp->irq, esp_intr);
+ esp_deallocate(esp);
+ scsi_unregister(esp->ehost);
+ return 0;
+ }

/*
* 86C01 handles DMA, IO mode, from address

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/