Re: [PATCH][RFC] mm: swsusp shrink_all_memory tweaks

[Nick Piggin]

Con Kolivas wrote:
> cc'ed GregKH for comment hopefully.

> > You did the right thing there by introducing the accessor, which moves the
> > ifdef out of code that wants to query the member right? But you can still
> > leave it in the .c file if it is local (which it is).
>
>
> Once again I'm happy to do the right thing; I'm just not sure what that is.

Well, struct scan_control escaping from vmscan.c is not the right thing
(try to get that past Andrew!). Obviously in this case, having the ifdef
in the .c file is OK.

I guess Greg's presentation is a first order approximation to get people
thinking in the right way. I mean we do it all the time, and in core kernel
code too (our favourite sched.c is a prime example).

--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/