Re: [patch 1/2] Validate itimer timeval from userspace

From: Andrew Morton
Date: Sat Mar 18 2006 - 16:05:23 EST


Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
>
> On Sat, 2006-03-18 at 21:23 +0100, Jesper Juhl wrote:
>
> > Wouldn't this only break existing applications that do incorrect
> > things (passing invalid values) ?
> > If that's the case I'd say breaking them is OK and we should change to
> > follow the spec.
> >
> > I don't like potential userspace breakage any more than the next guy,
> > but if the breakage only affects buggy applications then I think it's
> > more acceptable.
>
> Yes, it only breaks buggy applications.

But we live in the real world. There could be four-year-old applications
which passed all their Linux QA and which work perfectly well.

Then the kernel guys make some correctness change and that application
totally fails on new kernels. Your choice is a) don't use new kernels or
b) hold off the new kernel until your provider (if the company or internal
group still exists) has put out a new version of the application and then
you wear the (considerable) cost of upgrading what was a perfectly-running
application.

And whose fault was it? Ours. Because older kernels had the wrong
checking (thus causing that app's QA to pass) and because later kernels
changed the rules.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/