Re: [PATCH 07/23] readahead: insert cond_resched() calls

[Lee Revell]

On Sun, 2006-03-19 at 10:34 +0800, Wu Fengguang wrote:
> plain text document attachment
> (readahead-insert-cond_resched-calls.patch)
> Since the VM_MAX_READAHEAD is greatly enlarged and the algorithm become more
> complex, it becomes necessary to insert some cond_resched() calls in the
> read-ahead path.
> 
> If desktop users still feel audio jitters with the new read-ahead code,
> please try one of the following ways to get rid of it:
> 
> 1) compile kernel with CONFIG_PREEMPT_VOLUNTARY/CONFIG_PREEMPT
> 2) reduce the read-ahead request size by running
> 	blockdev --setra 256 /dev/hda # or whatever device you are using

Do you have any numbers on this (say, from Ingo's latency tracer)?  Have
you confirmed it's not a latency regression with the default settings?

Lee

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/