Re: [PATCH] fix potential null pointer deref in quota
From: Jesper Juhl
Date: Mon Mar 20 2006 - 02:58:54 EST
On 3/20/06, Andrew Morton <akpm@xxxxxxxx> wrote:
> Jesper Juhl <jesper.juhl@xxxxxxxxx> wrote:
> > The coverity checker noticed that we may pass a NULL super_block to
> > do_quotactl() that dereferences it.
> > Dereferencing NULL pointers is bad medicine, better check and fail
> > gracefully.
> I'd have thought that check_quotactl_valid() would be the appropriate place
> for this check. Jan, can you please sort out what we need to do here?
You may well be right. I openly admit that this is the first time I've
ever stuck my head in the quota code. I picked the location I did
simply because I thought making the function resistant to being passed
invalid data was the sane thing to do, but there may well be a more
logical place to fix it.
Jesper Juhl <jesper.juhl@xxxxxxxxx>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/