Re: Parenthesize macros in xfs

From: Jan Engelhardt
Date: Mon Mar 20 2006 - 16:37:07 EST

>> Hello xfs list,
>Hi Jan,
>> while browsing through the xfs/linux source, I noticed that many macros do
>> not do proper bracing. I have started to cook up a patch, but would like
>> feedback first before I continue for nothing.
>> It goes like this:
>> ...
>That looks fine. Please be sure to work on the -mm tree or on
>CVS on, so as to reduce your level of patch conflict.

Hm, would not it even be better to make them 'static inline' functions?

Jan Engelhardt
| Software Engineer and Linux/Unix Network Administrator
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at