Re: [PATCH 2.6.16-rc6-xen] export Xen Hypervisor attributesto sysfs

From: Arjan van de Ven
Date: Tue Mar 21 2006 - 06:08:06 EST


On Tue, 2006-03-21 at 05:44 -0500, Mike D. Day wrote:
> Arjan van de Ven wrote:
>
> >> +---properties
> >> | >---capabilities
> >> | >---changeset
> >
> > how is this a property and not part of version?
> Agree, changeset should be part of version
>
> > again what is the justification of putting this in the kernel? I though
> > everyone here was agreed that since the management tools that need this
> > talk to the hypervisor ANYWAY, they might as well just ask this
> > information as well....
>
> I think we had a good discussion but short of agreement. Some tools want to
> read a file from /sys/hypervisor/ rather than call a c lib. (In other words,
> not all tools will talk to the hypervisor.) It is appropriate to view the
> hypervisor as a hardware device so it is appropriate to have some information
> in sysfs.

then make a simple tool that gives the info to stdout


> I appreciate the counter argument as well, but think this should be a
> configurable option.

"a config option" is a cop-out. By proposing a config option you even
admit it's not essential for userspace. The last thing this should be is
a config option; it either is needed and important, and should be there
always, or it's redundant and should be done in userspace. "A config
option" is just admitting that it is the later, but that you need to
justify the time you spent on the kernel patch somewhere ;-)



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/