Re: [PATCH 2/2] Blackfin serial driver for kernel 2.6.16

From: Russell King
Date: Tue Mar 21 2006 - 06:24:00 EST

On Tue, Mar 21, 2006 at 03:45:57PM +0800, Luke Yang wrote:
> On 3/20/06, Russell King <rmk+lkml@xxxxxxxxxxxxxxxx> wrote:
> > On Mon, Mar 20, 2006 at 06:07:44PM +0800, Luke Yang wrote:
> > > Index: git/linux-2.6/drivers/serial/bfin_serial_5xx.c
> > > ===================================================================
> > > --- /dev/null
> > > +++ linux-2.6/drivers/serial/bfin_serial_5xx.c
> >
> > Please convert this driver to use the serial_core infrastructure. Thanks.
> Thank you! This is a driver based on the 68328 serial driver. Do
> you mean every serial driver must follow the serial core framework? If
> so, we'll change it ASAP. For now, my previous blackfin architecture
> patch needs this driver to get compiled.

It is preferable since it massively reduces code duplication, and fixes
various minor issues found in the original serial driver.

As a result, it improves code maintainability since a fix to the semantics
of the serial layer will fix all drivers, instead of having to apply the
same fix to multiple serial drivers (which just doesn't happen.)

Russell King
Linux kernel 2.6 ARM Linux -
maintainer of: 2.6 Serial core
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at