Re: [PATCH][8/8] mm: lru interface change
From: Arjan van de Ven
Date: Tue Mar 21 2006 - 08:10:41 EST
> > + page->wired_count ++;
> Oh dear, I missed this change you made to struct page, tucked away in 5/8.
> This alone pretty much makes it a showstopper, I'm afraid. You'll have to
> work out some other way to do it so as not to penalise 99.999% of machines
> which don't need this.
> (Oh, and making the field a short usually won't help either, because of
> alignment constraints).
it's not that hard even. All you need to do is make the vm be lazy about
it; if it encounters a pinned page during scanning, move it THEN to the
pinned list. If it then gets pinned more no issue. The first unpin then
moves it back to the normal list (yes it's still pinned), but the first
time the VM sees it it goes right back to the pinned list.
That way there's no need to keep a "pin depth" at all...
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/