Re: [PATCH] 2.6.xx: sata_mv: another critical fix

From: Sander
Date: Wed Mar 22 2006 - 00:45:34 EST


Jeff Garzik wrote (ao):
> Linus Torvalds wrote:
> >Maybe back-porting any critical sata_mv fixes to 2.6.16.x is appropriate,
> >considering that I don't think RH or SuSE will necessarily want to pull
> >the whole thing.

I'll try the 2.6.16-git3 snapshot.

> Agreed -- in theory -- but I'll let Mark Lord or somebody else do that,
> if they are motivated. sata_mv is labelled "HIGHLY EXPERIMENTAL" for a
> reason :) Its a known bug report generator, with bugs far outpacing
> fixes at present.
>
> Key patches to backport or test, in priority order, would be:
>
> [libata sata_mv] do not enable PCI MSI by default

Is this in -rc6-mm2 already? Because just for fun I enabled
CONFIG_PCI_MSI=y in my -rc6-mm2 .config and it still is rock stable.

> After that, you're at the mercy of not-yet-worked-around hardware bugs,
> and (as Mark Lord appears to be finding) some driver bugs as well.
>
> sata_mv development slowed to a trickle for a long time, after the
> original developer disappeared, and I didn't have time to dig deep into
> the hardware details. Mark Lord recently started picking up the pieces,
> so things are looking much better already. I have another patch from
> Mark to forward to you and 2.6.16.x (stable@), coming to you today.

Things indeed look much, much better. I'll try and find some more
serious fs tests and hit -rc6-mm2.

Thank you all for your work on this driver! I'll order two more of these
fine controllers.

Sander

--
Humilis IT Services and Solutions
http://www.humilis.net
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/