Re: [RFC PATCH 25/35] Add Xen time abstractions

From: Arjan van de Ven
Date: Wed Mar 22 2006 - 03:35:51 EST



> # We must build both images before we can assemble it.
> --- /dev/null
> +++ xen-subarch-2.6/arch/i386/mach-xen/time.c
> @@ -0,0 +1,1045 @@
> +/*
> + * linux/arch/i386/kernel/time.c

no it's not



is there any reason why this is a full copy rather than just a
subarching of the modified functions, or some simple hooks into the
generic function?

Duplication like this is evil because it means too many places need
duplicated bugfixes and rework (and such rework is underway)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/