Re: [RFC PATCH 30/35] Add generic_page_range() function

From: Nick Piggin
Date: Wed Mar 22 2006 - 19:23:55 EST

Keir Fraser wrote:

lastly, you don't allow any control over the type of pages that are
walked: this could well be unusably slow for some cases. At least
you should proably design the interface so we can iterate over
present, not present, all, etc so it becomes widely usable. Normally
I'd say to wait until users come up but in this case the function
isn't a speed demon anyway, and you also don't want to give people
any excuses not to use it.

You mean iterate only over PTEs that are already present, or only those that were *not* previously present, or all (present and non-present)? Is that really useful? If so then yes, it's not hard to add.

Yes. If you look at all the code that walks pagetables (including those
that just operate on a single pte) in arch/ and other places, there is
a fair diversity. A function called generic_page_range() would surely be
able to replace all those ;)

SUSE Labs, Novell Inc.
Send instant messages to your online friends -
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at