Re: 2.6.16-mm1

From: OGAWA Hirofumi
Date: Mon Mar 27 2006 - 11:21:49 EST


Jens Axboe <axboe@xxxxxxx> writes:

> On Fri, Mar 24 2006, Brandon Low wrote:
>
> Hmm, no luck reproducing this so far, strange. I'm using
> 2.6.16-block.git cfq branch exclusively, which is the patch you backed
> out. I guess I'll try 2.6.16-mm1 on the same box next.
>
> Can you try 2.6.16-mm1 with this patch applied on top?
>
> diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
> index 81edf51..89fcc2c 100644
> --- a/block/cfq-iosched.c
> +++ b/block/cfq-iosched.c
> @@ -1516,6 +1516,7 @@ cfq_cic_rb_add(struct cfq_data *cfqd, st
>
> rb_link_node(&cic->rb_node, parent, p);
> rb_insert_color(&cic->rb_node, &ioc->cic_root);
> + list_add(&cic->queue_list, &cfqd->cic_list);
> read_unlock(&cfq_exit_lock);
> }

I've got a same oops in 2.6.16-mm1, and this patch seems to fix it at
least in my case.

Thanks.
--
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/