Re: [PATCH] edac_752x needs CONFIG_HOTPLUG

From: Randy.Dunlap
Date: Mon Mar 27 2006 - 18:44:10 EST


On Mon, 27 Mar 2006 15:40:55 -0800 Andrew Morton wrote:

> "Randy.Dunlap" <rdunlap@xxxxxxxxxxxx> wrote:
> >
> > EDAC_752X uses pci_scan_single_device(), which is only available
> > if CONFIG_HOTPLUG is enabled
>
> hm. That's not a hotpluggable device, surely?
>
> If not then either a) PCI should be implementing pci_scan_single_device()
> if !CONFIG_HOTPLUG or b) EDAC shouldn't be using pci_scan_single_device().

or just that one if block should be surrounded by CONFIG_HOTPLUG
(done cleanly, of course).

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/