Re: sata_mv: module reloading doesn't work

[Mark Lord]

Dan Aloni wrote:
> On Sun, Apr 02, 2006 at 12:05:46PM -0400, Mark Lord wrote:
>
> > What kernel?  Any patches applied to sata_mv.c ??
>
> 2.6.16 + ncq branch. sata_mv.c was modified by me - I'll retry
> with a cleaner configuration, sorry.

The NCQ stuff is *unsafe* with the existing sata_mv.c,
as there are known (to me, at least) bugs that prevent it
from working reliably after the first I/O error of any kind.

The 2.6.16.1 branch is slightly better,
and there is also the "three bug fixes" update
that's in upstream to help things further.

With all of those fixes, the module loads/unloads/reloads fine for me.

If you want to use NCQ more safely, then you'll need to modify
the mv_start_dma() routine to reinitialize the queue pointers
each time, as they can get out of sync after an error.

There are still other bugs to be worked out and fixed, though.

I'll have a patch or two this week for the ones I know about.

Cheers

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/