Re: [patch 1/1] sys_sync_file_range()

From: Andrew Morton
Date: Mon Apr 03 2006 - 17:19:46 EST


Jens Axboe <axboe@xxxxxxx> wrote:
>
> > > I don't think any disagrees with you, the sync-write process flag is
> > > indeed an atrocious beast...
> >
> > Yeah. PF_SYNCWRITE was a performance tweak for the anticipatory scheduler.
> > As cfq is using it as well now (hopefully to good effect) I guess it could
> > be formalised more.
>
> Yup, both 'as' and 'cfq' would prefer to just look at a SYNC bio flag
> instead. But the logic itself is definitely needed.

hm. I actually thought we were already doing that. We should at least
tranfer PF_SYNCWRITE into bi_flags at the point where we start to construct
the BIO.

That might well fix RAID, too. If it's handing work off to another thread
via BIOs.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/