Re: [2.6.16 PATCH] Filessytem Events Reporter V2

From: Yi Yang
Date: Wed Apr 05 2006 - 19:48:26 EST


Carlos Silva wrote:
On Wed, 2006-04-05 at 21:21 +0800, Yi Yang wrote:
<snip>
+static void cleanup_dead_listener(listener * x)
+{
+ pid_filter * p = NULL, * pq = NULL;
+ uid_filter * u = NULL, * uq = NULL;
+ gid_filter * g = NULL, * gq = NULL;
+
+ if (p == NULL)
+ return;
<snip>

I think you ment "if (x == NULL)" here. Otherwise, the condition will always be true.
btw, I'm not reviewing your code, just stumbled across this while reading it.
Yes, it is my mistake, thank you.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/