[PATCH 2/2] writeback: fix range handling

From: OGAWA Hirofumi
Date: Thu Apr 06 2006 - 12:19:26 EST


reiser4 doesn't check wbc->end, and perhaps it does not use cyclic
behavior. So, I guess this is ok.

Could you review this?
---

fs/reiser4/entd.c | 8 ++++----
fs/reiser4/plugin/file/file.c | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)

diff -puN fs/reiser4/entd.c~wbc-range-cleanup-reiser4 fs/reiser4/entd.c
--- linux-2.6-akpm/fs/reiser4/entd.c~wbc-range-cleanup-reiser4 2006-04-06 05:44:56.000000000 +0900
+++ linux-2.6-akpm-hirofumi/fs/reiser4/entd.c 2006-04-06 05:44:56.000000000 +0900
@@ -265,14 +265,14 @@ static void entd_flush(struct super_bloc
init_stack_context(&ctx, super);
ctx.entd = 1;

- rq->wbc->start = rq->page->index << PAGE_CACHE_SHIFT;
- rq->wbc->end = (rq->page->index + ENTD_CAPTURE_APAGE_BURST) << PAGE_CACHE_SHIFT;
+ rq->wbc->range_start = rq->page->index << PAGE_CACHE_SHIFT;
+ rq->wbc->range_end = (rq->page->index + ENTD_CAPTURE_APAGE_BURST) << PAGE_CACHE_SHIFT;
tmp = rq->wbc->nr_to_write;
rq->mapping->a_ops->writepages(rq->mapping, rq->wbc);

if (rq->wbc->nr_to_write > 0) {
- rq->wbc->start = 0;
- rq->wbc->end = 0;
+ rq->wbc->range_start = 0;
+ rq->wbc->range_end = LLONG_MAX;
generic_sync_sb_inodes(super, rq->wbc);
}
rq->wbc->nr_to_write = ENTD_CAPTURE_APAGE_BURST;
diff -puN fs/reiser4/plugin/file/file.c~wbc-range-cleanup-reiser4 fs/reiser4/plugin/file/file.c
--- linux-2.6-akpm/fs/reiser4/plugin/file/file.c~wbc-range-cleanup-reiser4 2006-04-06 05:44:56.000000000 +0900
+++ linux-2.6-akpm-hirofumi/fs/reiser4/plugin/file/file.c 2006-04-06 05:44:56.000000000 +0900
@@ -1550,7 +1550,7 @@ writepages_unix_file(struct address_spac
result = 0;
goto end;
}
- jindex = pindex = wbc->start >> PAGE_CACHE_SHIFT;
+ jindex = pindex = wbc->range_start >> PAGE_CACHE_SHIFT;
result = 0;
nr_pages =
(i_size_read(inode) + PAGE_CACHE_SIZE - 1) >> PAGE_CACHE_SHIFT;
_
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/