Re: [patch] ipv4: initialize arp_tbl rw lock

From: David S. Miller
Date: Sat Apr 08 2006 - 06:14:31 EST


From: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
Date: Sat, 8 Apr 2006 12:02:13 +0200

> Ok, so the problem seems to be that inet_init gets called after qeth_init.
> Looking at the top level Makefile this seems to be true for all network
> drivers in drivers/net/ and drivers/s390/net/ since we have
>
> vmlinux-main := $(core-y) $(libs-y) $(drivers-y) $(net-y)
>
> The patch below works for me... I guess there must be a better way to make
> sure that any networking driver's initcall is made before inet_init?
>
> Signed-off-by: Heiko Carstens <heiko.carstens@xxxxxxxxxx>

We could make inet_init() a subsystem init but I vaguely recall
that we were doing that at one point and it broke things for
some reason.

Perhaps fs_initcall() would work better. Or if that causes
problems we could create a net_initcall() that sits between
fs_initcall() and device_initcall().

Or any other ideas?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/