Re: [PATCH rc1-mm 3/3] coredump: copy_process: don't check SIGNAL_GROUP_EXIT

From: Roland McGrath
Date: Mon Apr 10 2006 - 03:13:24 EST


> After the previous patch SIGNAL_GROUP_EXIT implies a pending SIGKILL,
> we can remove this check from copy_process() because we already checked
> !signal_pending().

My SIGNAL_GROUP_EXEC change made this spot check for either flag, but this
already holds true for the exec case and so my change to this check here
was not needed. With the coredump change done, I concur that the exit
cases are covered too and so this check can go. For paranoia's sake,
perhaps we should leave behind a BUG_ON.


Thanks,
Roland
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/