[PATCH] m41t00: fix bitmasks when writing to chip

From: amatus@xxxxxxxxxx
Date: Wed Apr 12 2006 - 12:58:31 EST


From: David Barksdale <amatus@xxxxxxxxxx>

This patch fixes the bitmasks used when writing to the M41T00 registers.
The origional code used a mask of 0x7f when writing to each register,
this is incorrect and probably the result of a copy-paste error. As a
result years from 1980 to 1999 will be read back as 2000 to 2019.

Signed-off-by: David Barksdale <amatus@xxxxxxxxxx>

---

The following patch is against the 2.6.16.4 linux kernel

--- linux-2.6.16.4/drivers/i2c/chips/m41t00.c.orig 2006-04-12 11:28:04.740793700 -0500
+++ linux-2.6.16.4/drivers/i2c/chips/m41t00.c 2006-04-12 11:29:58.093959100 -0500
@@ -129,13 +129,13 @@ m41t00_set_tlet(ulong arg)
if ((i2c_smbus_write_byte_data(save_client, 0, tm.tm_sec & 0x7f) < 0)
|| (i2c_smbus_write_byte_data(save_client, 1, tm.tm_min & 0x7f)
< 0)
- || (i2c_smbus_write_byte_data(save_client, 2, tm.tm_hour & 0x7f)
+ || (i2c_smbus_write_byte_data(save_client, 2, tm.tm_hour & 0x3f)
< 0)
- || (i2c_smbus_write_byte_data(save_client, 4, tm.tm_mday & 0x7f)
+ || (i2c_smbus_write_byte_data(save_client, 4, tm.tm_mday & 0x3f)
< 0)
- || (i2c_smbus_write_byte_data(save_client, 5, tm.tm_mon & 0x7f)
+ || (i2c_smbus_write_byte_data(save_client, 5, tm.tm_mon & 0x1f)
< 0)
- || (i2c_smbus_write_byte_data(save_client, 6, tm.tm_year & 0x7f)
+ || (i2c_smbus_write_byte_data(save_client, 6, tm.tm_year & 0xff)
< 0))

dev_warn(&save_client->dev,"m41t00: can't write to rtc chip\n");
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/