Re: [PATCH] IPMI: fix devinit placement

From: Corey Minyard
Date: Wed Apr 12 2006 - 14:22:59 EST


Looks fine to me. Thanks.

-Corey

Randy.Dunlap wrote:

>From: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
>
>gcc complains about __devinit in the wrong location:
>drivers/char/ipmi/ipmi_si_intf.c:2205: warning: '__section__' attribute does not apply to types
>
>Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
>---
> drivers/char/ipmi/ipmi_si_intf.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>--- linux-2617-rc1g5.orig/drivers/char/ipmi/ipmi_si_intf.c
>+++ linux-2617-rc1g5/drivers/char/ipmi/ipmi_si_intf.c
>@@ -2198,11 +2198,11 @@ static inline void wait_for_timer_and_th
> }
> }
>
>-static struct ipmi_default_vals
>+static __devinit struct ipmi_default_vals
> {
> int type;
> int port;
>-} __devinit ipmi_defaults[] =
>+} ipmi_defaults[] =
> {
> { .type = SI_KCS, .port = 0xca2 },
> { .type = SI_SMIC, .port = 0xca9 },
>
>
>---
>
>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/