Re: [PATCH] [2/2] POWERPC: Lower threshold for DART enablement to 1GB, V2

From: Olof Johansson
Date: Thu Apr 13 2006 - 18:27:57 EST


On Fri, Apr 14, 2006 at 06:51:55AM +1000, Benjamin Herrenschmidt wrote:

> an improvement with the DART thanks to virtual merging. Currently, we
> pay a cost due to our stupid invalidate mecanism that we should really
> fix by shooting the TLB directly.

What was keeping me from implementing this before was the lack of public
documentation on how to do it. Has that changed? I'd be happy to do the
implementation.

> Also have you made sure all your
> additions for handling crappy hardware are nicely wrapped in unlikely()
> statements ? :)

I would expect the dynamic predictor to work quite well on this. I'm not
worried about the overhead of the tests as much as the overhead of
having to enable the DART for smaller configs. If benchmark profiling
shows different down the road then we can add them.


-Olof
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/