Re: [PATCH] Remove unnecessary kmalloc/kfree calls in mtdchar

From: David Woodhouse
Date: Mon Apr 17 2006 - 10:50:59 EST


On Mon, 2006-04-17 at 10:19 -0300, Thiago Galesi wrote:
>
> + if (!kbuf) {
> + printk("kmalloc is null\n");
> + return -ENOMEM;
> + }

Don't printk -- especially without a priority. Either just bail out with
-ENOMEM or try a smaller size.

--
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/