[PATCH] -mm: make pmtmr_ioport __read_mostly

From: Andreas Mohr
Date: Tue Apr 18 2006 - 14:44:13 EST


Hello all,

- written on init only, accessed for every timer read --> __read_mostly
- fix broken sentence

Patch tested on 2.6.17-rc1-mm2, rediffed against 2.6.17-rc1-mm3.
I did not test the x86_64 part, though, for obvious reasons.

Signed-off-by: Andreas Mohr <andi@xxxxxxxx>


diff -urN linux-2.6.17-rc1-mm3.orig/drivers/clocksource/acpi_pm.c linux-2.6.17-rc1-mm3/drivers/clocksource/acpi_pm.c
--- linux-2.6.17-rc1-mm3.orig/drivers/clocksource/acpi_pm.c 2006-04-18 20:06:57.000000000 +0200
+++ linux-2.6.17-rc1-mm3/drivers/clocksource/acpi_pm.c 2006-04-18 20:08:19.000000000 +0200
@@ -30,7 +30,7 @@
* The location is detected during setup_arch(),
* in arch/i386/acpi/boot.c
*/
-u32 pmtmr_ioport;
+u32 pmtmr_ioport __read_mostly;

#define ACPI_PM_MASK 0xFFFFFF /* limit it to 24 bits */

@@ -47,7 +47,7 @@
/*
* It has been reported that because of various broken
* chipsets (ICH4, PIIX4 and PIIX4E) where the ACPI PM clock
- * source is not latched, so you must read it multiple
+ * source is not latched, you must read it multiple
* times to ensure a safe value is read:
*/
do {

diff -urN linux-2.6.17-rc1-mm3.orig/arch/x86_64/kernel/pmtimer.c linux-2.6.17-rc1-mm3/arch/x86_64/kernel/pmtimer.c
--- linux-2.6.17-rc1-mm3.orig/arch/x86_64/kernel/pmtimer.c 2006-04-03 05:22:10.000000000 +0200
+++ linux-2.6.17-rc1-mm3/arch/x86_64/kernel/pmtimer.c 2006-04-18 20:36:35.000000000 +0200
@@ -27,7 +27,7 @@
/* The I/O port the PMTMR resides at.
* The location is detected during setup_arch(),
* in arch/i386/kernel/acpi/boot.c */
-u32 pmtmr_ioport;
+u32 pmtmr_ioport __read_mostly;

/* value of the Power timer at last timer interrupt */
static u32 offset_delay;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/