Re: Linux 2.6.16.7

[Alexander E. Patrakov]

Greg KH wrote:
> On Tue, Apr 18, 2006 at 12:58:07PM +0600, Alexander E. Patrakov wrote:
>   
> > Greg KH wrote:
> >     
> > > -EXTRAVERSION = .6
> > > +EXTRAVERSION = .7
> > >       
> > Hello, I would like to know if there is a plan to include this in the next 
> > -stable update?
> >
> > http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blobdiff;h=2731570eba5b35a21c311dd587057c39805082f1;hp=dfb62998866ae2e298139164a85ec0757b7f3fc7;hb=9469d458b90bfb9117cbb488cfa645d94c3921b1;f=net/core/dev.c
> >     
>
> No one has submitted it to the stable@xxxxxxxxxx mail address from what
> I can see, so no, it is not in the queue.  If you think otherwise,
> please send it.
>   
Without that patch, there is a race when registering network interfaces 
and renaming it with udev rules, because initially the "address" in 
sysfs doesn't contain useful data. See 
http://marc.theaimsgroup.com/?t=114460338900002&r=1&w=2

Breaking the recommended way of assigning persistent network interface 
names is, IMHO, a bug serious enough to be fixed in -stable.

Signed-off-by: Alexander E. Patrakov <patrakov@xxxxxxxxxx>

---

--- linux-2.6.16.5/net/core/dev.c
+++ linux-2.6.16.5/net/core/dev.c
@@ -2932,11 +2932,11 @@

		switch(dev->reg_state) {
		case NETREG_REGISTERING:
+			dev->reg_state = NETREG_REGISTERED;
			err = netdev_register_sysfs(dev);
			if (err)
				printk(KERN_ERR "%s: failed sysfs registration (%d)\n",
				       dev->name, err);
-			dev->reg_state = NETREG_REGISTERED;
			break;

		case NETREG_UNREGISTERING:

--
Alexander E. Patrakov

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/