Re: RFC: rename arch/arm/mach-s3c2410 to arch/arm/mach-s3c24xx

[Komal Shah]

--- Dimitry Andric <dimitry@xxxxxxxxxx> wrote:

> Ben Dooks wrote:
> > With the advent of the s3c2410 port adding support for
> > more of the samsung SoC product line (s3c2440, s3c2442,
> > s3c2400) there have been several requests by other people
> > to rename the (in their opinion) increasingly inaccurate
> > arch/arm/mach-s3c2410 to arch/arm/mach-s3c24xx.
> 
> Well, if you start this way, you might also consider renaming it to
> mach-s3cxxxx, since Samsung also seems to have S3C3410, S3C44B0 and
> who
> knows what else.  Otherwise you'd maybe have to do such an operation
> again in the future...
> 
> Also, I've always found the dichotomy of having
> "include/asm-arm/arch-s3c2410" and "arch/arm/mach-s3c2410" rather
> weird.
> Isn't s3cxxxx an "architecture", instead of a specific machine?  If
> so,
> arch/arm/arch-s3cxxxx would be more logical.

I am not sure, this will apply to Samsung chips or not. But in case of
TI OMAP we had separated the directories based on the "Generation" of
processors produced by TI, which is OMAP1 (OMAP1510, OMAP1610,
OMAP1710, OMAP730, OMAP5910, OMAP5912) and OMAP2 (OMAP2420, OMAP2430 -
(2430 support is not added to git tree yet)). So directory structure
now becomes like

arch/arm/mach-omap1
arch/arm/mach-omap2
include/asm-arm/arch-omap
arch/arm/plat-omap - This directory contains the things which are
common between OMAP1 and OMAP2 generation of processors and can be
#ifdefed with specific CONFIG_ARCH_OMAP1/2. e.g gpio, dma apis etc.

---Komal Shah
http://komalshah.blogspot.com/

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/