Re: [discuss] Re: [PATCH] [6/6] i386: Move CONFIG_DOUBLEFAULT into arch/i386 where it belongs.

[Adrian Bunk]

On Tue, Apr 18, 2006 at 07:08:39PM -0700, Randy.Dunlap wrote:
> On Tue, 18 Apr 2006 22:12:13 +0200 Andi Kleen wrote:
> 
> > On Tuesday 18 April 2006 21:05, Adrian Bunk wrote:
> > > On Tue, Apr 18, 2006 at 12:35:22PM +0200, Andi Kleen wrote:
> > > > 
> > > > Signed-off-by: Andi Kleen <ak@xxxxxxx>
> > > >...
> > > 
> > > NAK.
> > >  submitting a patch that is the revert of a patch that went 
> > > into Linus' tree just 8 days ago [1], I'd expect at least:
> > > - a Cc to the people involved with the patch you are reverting
> > > - a note that you are reverting a recent patch in your patch
> > >   description
> > > - an explanation why you disagree with the patch you are reverting
> > 
> > The subject was very clear. i386 options belong into arch/i386.
> 
> Yes, the timing could have been better.  Whatever.
> 
> I agree with Andi that it should be moved back to the ix86 Processor
> menu, but not where he moved it to.  My patch is below.
>...

I'd still disagree with Andi regarding this point (but it's not a very 
important issue).

My main problem with his patch is still the way he did it - sending a 
patch reverting a recently included patch with neither discussion before 
the patch nor mentioning in the patch that it's a revert nor a Cc to the 
people involved with the patch.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/