Re: [PATCH 1/7] FS-Cache: Provide a filesystem-specific sync'ablepage bit

[Andrew Morton]

David Howells <dhowells@xxxxxxxxxx> wrote:
>
> Andrew Morton <akpm@xxxxxxxx> wrote:
> 
> > It would be better to rename PG_checked to PG_fs_misc kernel-wide.
> 
> So would deleting PG_checked and changing the PageChecked() macros to:
> 
> 	#define PageChecked(page)		PageFsMisc((page))
> 	#define SetPageChecked(page)		SetPageFsMisc((page))
> 	#define ClearPageChecked(page)		ClearPageFsMisc((page))
> 
> be acceptable?  Or would you rather I replaced those too?
> 

PG_checked is presently a misc bit which only filesystems use.  So yes, I'd
say it's appropriate to remove PageChecked() and friends altogether.

That might break out-of-tree filesystems, but they'll work it out.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/