Re: [patch 05/22] : Fix hotplug race during device registration

From: Alexander E. Patrakov
Date: Fri Apr 21 2006 - 09:18:46 EST


Chris Rankin wrote:
With reference to this patch:
http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blobdiff;h=2731570eba5b35a21c311dd587057c39805082f1;hp=dfb62998866ae2e298139164a85ec0757b7f3fc7;hb=9469d458b90bfb9117cbb488cfa645d94c3921b1;f=net/core/dev.c

Doesn't this patch introduce another bug when registration fails, because reg_state is left as
NETREG_REGISTERED?

Look at the old code again. This is not a new bug. The old code fails registration, does a printk, and then sets dev->reg_state = NETREG_REGISTERED. So this doesn't revoke my signed-off-by line.

--
Alexander E. Patrakov
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/