Re: [PATCH] Shrink rbtree

From: David Woodhouse
Date: Fri Apr 21 2006 - 18:13:26 EST


On Fri, 2006-04-21 at 21:57 +0100, Hugh Dickins wrote:
>
> } __attribute__((aligned(sizeof(long))));
> /*
> * On most architectures that alignment is already the case; but
> * must be enforced here for CRIS, to let the least signficant bit
> * of struct page's "mapping" pointer be used for PAGE_MAPPING_ANON.
> */
>
> You can often get away with it - I notice we never added the same
> alignment to struct anon_vma, which in theory needed it just as much.
> Some accident of how structures are packed into slabs on CRIS, I suppose.

That sounds very strange to me, but it's harmless enough to add the
explicit alignment.

--
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/