Re: kfree(NULL)

From: Andrew Morton
Date: Fri Apr 21 2006 - 19:22:41 EST


"Hua Zhong" <hzhong@xxxxxxxxx> wrote:
>
> > struct likeliness {
> > char *file;
> > int line;
> > atomic_t true_count;
> > atomic_t false_count;
> > struct likeliness *next;
> > };
>
> It seems including atomic.h inside compiler.h is a bit tricky (might have interdependency).
>
> Can we just live with int instead of atomic_t? We don't really care about losing a count occasionally..

Sure, int or long would work OK.

> > It'll crash if a module gets registered then unloaded.
> > CONFIG_MODULE_UNLOAD=n would be required.
>
> What about init data that is thrown away after boot?

Good point. Putting #ifndef CONFIG_foo around init/main.c:init()'s call to
free_initmem would fix that.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/