Re: kfree(NULL)

From: Paul Mackerras
Date: Sat Apr 22 2006 - 13:17:03 EST


Pekka Enberg writes:

> No, it's not the janitors fault that we have paths doing lots of
> kfree(NULL) calls. NULL check removal didn't create the problem, but
> it makes it more visible definitely.

There is a judgement to be made at each call site of kfree (and
similar functions) about whether the argument is rarely NULL, or could
often be NULL. If the janitors have been making this judgement, I
apologise, but I haven't seen them doing that.

Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/